Repository navigation
Conversation
Collaborator
…job of CheckpointAfterAllTasksFinishedITCase The test was originally meant to enable checkpointing with a large interval, so no checkpoint is effectively triggered. Since FLINK-38939 the coordinator re-schedules the periodic trigger based on mean pause. With the default min pause of 0 a periodic checkpoint fires as soon as all tasks are running. That early checkpoint lets the subtasks that were finished on restore (sourceA, passA -> sinkA) complete and exit immediately. The end-of-data checkpoint is queued behind it and triggered against a plan that still lists those subtasks as RUNNING. If one of them reaches FINISHED on the TaskManager before the trigger arrives, it declines with CHECKPOINT_DECLINED_TASK_NOT_READY. That reason is ignored by the CheckpointFailureManager, the end-of-data trigger is not retried, and no periodic checkpoint follows, so sourceB waits forever in StreamTask.afterInvoke for a final checkpoint and the passB -> sinkB subtasks wait for its end-of-partition. Set the min pause of the restored job to one year, the maximum the coordinator accepts. The pause gates periodic triggers only, so the end-of-data checkpoint still fires at once, while every scheduler start or restart now waits longer than the test can run. All tasks then wait for the same final checkpoint and none can finish before it is taken, which removes the race instead of recovering from it. Generated-by: Claude Code (Claude Fable 5.1)
Efrat19
force-pushed
the
FLINK-33186-b
branch
from
October 19, 2026 06:01
71a3f2a to
dcc2cae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Fix flakiness in
testRestoreAfterSomeTasksFinishedcaused by periodic checkpointingThe test was originally meant to enable checkpointing with a large interval, so no checkpoint is effectively triggered.
Since FLINK-38939 the coordinator re-schedules the periodic trigger based on mean pause. With the default min pause of 0 a periodic checkpoint fires as soon as all tasks are running.
Brief change log
minPauseBetweenCheckpointsVerifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation
Was generative AI tooling used to co-author this PR?
Co-Generated-by: Claude Code (Claude Fable 5.1)